test(bigquery): add integration tests for row-based query() with Arrow format - #14413
Conversation
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new integration tests for row-based queries using the Arrow format, covering both single-page and multi-page scenarios, and refines existing Arrow query tests with more precise batch count assertions. The review feedback recommends adding an assertion for the selected 'TIMESTAMP' column in the new 'testQueryRowBasedWithArrowFormat' test to verify proper serialization and deserialization of timestamp values.
There was a problem hiding this comment.
Code Review
This pull request updates integration tests for Arrow query results by asserting batch counts and introduces two new tests, testQueryRowBasedWithArrowFormat and testQueryRowBasedWithArrowFormatMultiPage, to verify row-based querying with the Arrow format. The feedback suggests adding an assertion for the ts (timestamp) field in the new testQueryRowBasedWithArrowFormat test to ensure timestamp parsing is properly validated.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request updates integration tests in ITBigQueryTest.java by asserting specific batch counts for Arrow query results and introducing two new tests, testQueryRowBasedWithArrowFormat and testQueryRowBasedWithArrowFormatMultiPage, to verify row-based queries using the Arrow format. There are no review comments, so I have no feedback to provide.
b3cdc66 to
115a12e
Compare
115a12e to
eea4787
Compare
eea4787 to
d1ab4e1
Compare
lqiu96
left a comment
lqiu96
left a comment
There was a problem hiding this comment.
not a blocker for initial ITs.
d1ab4e1 to
20067ce
Compare
2 participants
Add integration tests verifying row-based
query()execution usingQueryResultsFormat.ARROWfor both single-page and multi-page results inITBigQueryTest.